Morning Session Peer to Peer Code Review | M2W5

[harlexkhal]

Even though this is not working at the time of this writing due to issues from your API providers. From the load screen, I can imagine it had a lovely user interface design behind it ⭐. also lovely code architectural design, almost similar to MVC architecture. 👏

• Just a few issues I noticed while going through the codes in the add comment section when a comment is added, the input value is not cleared before the Involvement API to add a new comment is called, this could cause an unexpected runtime bug when a user has slow network and makes multiple clicks on the submit button. A request could be stopped by disabling the submit button until the API gives back a response or by stopping the next add comment await process if there's already one on the request queue.

• Comments for documenting functions are better to put before functions not inside.

• The argument "exists" in createComments could be named differently to be more descriptive. Maybe firstTime to be true by default.

• Some functions like addComment could be implemented more in a functional way by passing the comment object to them.