Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #3

Merged
merged 4 commits into from Feb 16, 2022
Merged

Feature #3

merged 4 commits into from Feb 16, 2022

Conversation

awaisanwar544
Copy link
Owner

Features Added:

  1. Remove all hardcoded items from the tasks array.
  2. Create a new JavaScript file for the new functionality.
  3. Implement a function for adding a new task (add a new element to the array).
  4. Implement a function for deleting a task (remove an element from the array).
  5. Implement a function for editing task descriptions.
  6. By default, new tasks should have the property completed set to false and the property index set to the value of the new array length (i.e. if you're adding a 5th task to the list, the index of that task should equal to 5).
  7. Deleting a task should update all remaining items' indexes, so they represent the current list order and are unique.
  8. All changes to the To Do List should be saved in local storage.
new.mov

Copy link

@t-yanick t-yanick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @awaisanwar544,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@awaisanwar544 awaisanwar544 merged commit 4481fa9 into main Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants