Consider to use AssertJ instead of Hamcrest lib

[mrniko]

https://joel-costigliola.github.io/assertj/

[twillouer]

👍

[szpak]

@mrniko For internal tests in Awaitility? Or you would like to be able to use AssertJ assertions in your code (something that I implemented in Awaitility 1.6.0 almost 3 years ago)?

[johanhaleby]

Yes I also wonder what you mean since it has been supported for quite a while (see docs).

One thing that we could consider would be to make the dependency to Hamcrest optional, but it'll require some non-trivial work I think.

[longtimeago]

One thing that we could consider would be to make the dependency to Hamcrest optional

@johanhaleby This would be very-very nice! Many libs depend on hamcrest in a very nasty way. Some of them depends on very old version (1.1) which is not fully compatible with 1.3.
We would like to use Awaitility in production code but hamcrest compile dependency stops us :(
Thus, only test code so far ...

[johanhaleby]

Yes Hamcrest is tightly coupled to Awaitility. With a bit of work I think it ought to be possible to remove it from core and perhaps introduce a new library called awaitility-hamcrest. But it would not be backward compatible.

[longtimeago]

But it would not be backward compatible.

@johanhaleby Sure, this is expected cost and totally acceptable imo :)