Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do we have to sudo? #1

Open
zhouzhuojie opened this issue Sep 19, 2014 · 1 comment
Open

Why do we have to sudo? #1

zhouzhuojie opened this issue Sep 19, 2014 · 1 comment

Comments

@zhouzhuojie
Copy link

sudo ./run_nightwatch.sh

and

sudo npm install nightwatch@0.5.3 in launch_nightwatch_from_package.sh.

Can we just use npm install -g nightwatch and avoid using sudo? It feels like a security issue here.

@awatson1978
Copy link
Owner

Feel free to try removing either one of them. You'll find that errors get created with each. Remove the sudo from ./run_nightwatch.sh and the script doesn't have permission to write reports to disk. Remove the sudo from npm install -g nightwatch and nightwatch can't get installed.

I'm not against tweaking the file permissions to get the script to run without sudo references. But the Selenium server is a separate binary that needs access to write files to disk and launch separate processes. So it's not immediately obvious how to go about removing the sudo references and keep everything working.

I'd consider a pull-request (on a separate feature-branch) if you've got some ideas on how to keep all the functionality while removing the sudo references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants