Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working in Modals Anymore #369

Open
AlexisSerneels opened this issue Apr 20, 2024 · 3 comments
Open

Not working in Modals Anymore #369

AlexisSerneels opened this issue Apr 20, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@AlexisSerneels
Copy link

AlexisSerneels commented Apr 20, 2024

Filament Version

v.3.2.70

Plugin Version

v.3.3.2

PHP Version

PHP 8.2

Problem description

Since this release : https://github.com/awcodes/filament-tiptap-editor/releases/tag/v3.3.0, this.editor() is underfinedis returned when trying to insert a link, or add a media, etc.
This happens for me when using the editor with an Modal from a RelationManager.

Reverting to v3.2.27 fixes the issue.

CleanShot 2024-04-19 at 09 42 13@2x

Expected behavior

We expect to be able to insert an image

Steps to reproduce

  • Add the field within a relation manager
  • Try inserting an image

Reproduction repository

No response

Relevant log output

No response

@AlexisSerneels AlexisSerneels added the bug Something isn't working label Apr 20, 2024
@awcodes
Copy link
Owner

awcodes commented Apr 20, 2024

Try running php artisan filament:assets you might not be serving the updated js file.

@AlexisSerneels
Copy link
Author

Hi.

That is the first thing I did. (seeing your other comment)

I’ll send you a reproduction repo in a few days if needed.

@awcodes
Copy link
Owner

awcodes commented Apr 20, 2024

Yes, please send a reproduction repo. That would help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants