-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content not updating when switching locales with filament/spatie-laravel-translatable-plugin #85
Comments
Seems like a regression. Will try to solve tomorrow. |
Seems like it only switches correctly for the first instance? When having multiple I'm on the latest version (2.2.10) |
Should be fixed with v2.2.11. |
Hello ! I still have a strange behaviour using : I have to switch many times before the tiptap editor actually reloads properly... I have 2 languages, french and english. On first page load : And then I have to repeat the same process to display the editor in english. The same behaviour occurs either if I have only one editor, or many... Edit : |
Ok. let me do some more digging. It should be respecting the app's default locale too. |
Yea, it seems to skip the first language switch. I have 3 languages:
|
Hmm. I can't replicate the issue. Only thing i'm seeing is that the language switcher doesn't honor the default locale, but that comes down to the order you in which you register the available locales for the resource. This is with Screen.Recording.2023-05-16.at.2.13.07.PM.mov |
It only happens with a sufficiently high amount of editor instances. On my form I originally had 26 TipTapEditors. Locally, it was working fine, however on the staging server the aforementioned issue kept showing up. Once I started adding even more fields (40-50+) I could also observe the same error locally. Not consistently every time, but sometimes the language switch just doesn't update the editor content. Weirdly enough, the same doesn't happen with the default Filament Unfortunately I can't spend any more time on researching this error, so I switched to the tiny-editor plugin for now, which doesn't have this issue. |
When using filament/spatie-laravel-translatable-plugin in conjunction with spatie/laravel-translatable, the content of the editor does not update when switching locales using the locale switcher from spatie/laravel-translatable. Specifically, after switching the locale, the content remains the same and does not reflect the updates made for the newly selected locale.
Versions
The text was updated successfully, but these errors were encountered: