Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCC-7 support #22

Closed
awdeorio opened this issue Feb 13, 2019 · 1 comment · Fixed by #30
Closed

GCC-7 support #22

awdeorio opened this issue Feb 13, 2019 · 1 comment · Fixed by #30

Comments

@awdeorio
Copy link
Owner

awdeorio commented Feb 13, 2019 •
edited
Loading

Compiling with GCC-7 yields the following error:

csvstream.h:113:13: error: this statement may fall through [-Werror=implicit-fallthrough=]
       state = UNQUOTED;
       ~~~~~~^~~~~~~~~~

Be sure to update .travis.yml to include gcc-7 in the build matrix.
@amirkamil
Copy link
Contributor

Adding

   [[gnu::fallthrough]];

after this line should fix it, as per https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/.

@awdeorio awdeorio mentioned this issue Apr 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GCC7 support awdeorio/csvstream
2 participants
@amirkamil @awdeorio