-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with act ? #11
Comments
Hey, I completely agree that all pros about integrating
Yes, this runner interface is quite general and I found myself doing really similar work as well. For the integration part, I considered this for a long time and I decided not to integrate it. My reasoning for keeping separate:
However, I would like to keep this conversation open and try to find common ground for integration with Maybe an easy one for integration could be building images with |
It appears that we can finally resolve this issue. The most recent plans for |
Hi! I was wondering what the pros/cons are of integrating with https://github.com/nektos/act.
The way I see it is:
Pros:
Cons:
About the minimal work:
I believe the main interface to be implemented is https://github.com/nektos/act/blob/f84a566ded8d03bc4daee36bb7df2502a8351409/pkg/runner/runner.go#L16 which is quite general. Like I said, there may be some parts of the upstream code where we'd need to add extension points but overall this seems doable.
What do you think?
The text was updated successfully, but these errors were encountered: