Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about application domain and equation parameters #50

Closed
EmanuelCastanho opened this issue Apr 18, 2024 · 1 comment · Fixed by #52
Closed

Question about application domain and equation parameters #50

EmanuelCastanho opened this issue Apr 18, 2024 · 1 comment · Fixed by #52
Labels
NEW INDEX New spectral index

Comments

@EmanuelCastanho
Copy link
Contributor

Hi,

I want to contribute with spectral indexes that are used to detect features at the surface of the ocean: oil spills (OSI), floating vegetation (FAI), floating debris (FDI, PI), ... Should I include these in the water domain? Should Floating Algae Index (FAI) be included in the vegetation domain, although it is applied on the ocean?

Also, FAI and FDI (Floating Debris Index) depend on the NIR and Red Edge 2 wavelengths that change between Sentinel-2A and Sentinel-2B. I see that lambdaN is already defined, but not lambdaRE2, does these parameters take into consideration Sentinel-2 A and B different values?

@EmanuelCastanho EmanuelCastanho added the NEW INDEX New spectral index label Apr 18, 2024
@davemlz
Copy link
Member

davemlz commented Apr 25, 2024

Hi @EmanuelCastanho!

I would say that as long as they are applied to water bodies you include them in the water domain ;) so, yes, you can put all of them in this category.

Regarding the lambdaRE2, it would be a user-defined parameter, so you can actually select the values you need (either S2A or S2B) when computing the index. Just remember to add the lambdaRE2 parameter here if you are submitting a PR: https://github.com/awesome-spectral-indices/awesome-spectral-indices/blob/main/src/constants.py. If you are submitting an issue I will add it ;)

Cheers!

David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NEW INDEX New spectral index
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants