Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd client move global by direction #2437
Comments
This comment has been minimized.
This comment has been minimized.
|
Here you go
|
This comment has been minimized.
This comment has been minimized.
|
i think it could be done as |
actionless
added
enhancement
good first issue
labels
Oct 16, 2018
This comment has been minimized.
This comment has been minimized.
|
In that case it would be If you implement a trivial swap by direction and the next client is floating and the origin isn't, you only have bad choice. Either you blindly swap them and it doesn't work. Either you make the target tiled and the origin floating, in which case you probably made your calculator or popup tiled by accident or you do nothing and it's confusing. It's better to keep separate logic for floating and tiled clients when it comes to swapping. So a global method on the client isn't gonna work. |
This comment has been minimized.
This comment has been minimized.
|
but move_to_screen is not swap, move means what the client just goes away from this screen to some other |
This comment has been minimized.
This comment has been minimized.
|
Ah, yeah, we could have that one. I always wanted to add move iterators and navigation methods to the screens to handle geometric navigation and iteration (from left to right, right to left, top to bottom, bottom to top) but I never did. |
This comment has been minimized.
This comment has been minimized.
|
but such kind of code should already reside in |
This comment has been minimized.
This comment has been minimized.
|
It is in |
This comment has been minimized.
This comment has been minimized.
|
I think |
darrenswhite commentedOct 15, 2018
Similar to how
awful.client.focus.global_bydirectionandawful.client.swap.global_bydirectionwork except for moving a client in a given direction. This would be nice to have if possible! Thanks.