Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

's output in OG meta #968

Closed
wpsmort opened this issue Jul 15, 2017 · 3 comments
Closed

's output in OG meta #968

wpsmort opened this issue Jul 15, 2017 · 3 comments
Labels
Milestone

Comments

@wpsmort
Copy link

wpsmort commented Jul 15, 2017

Whilst testing the release for v2.3.14.1 with the fix for issue #961 I found that the OG title and Twitter title have the incorrect character encoding. See source code below:

<title>Steve’s Post Title | Steve&apos;s Test Site</title>
<meta property="og:title" content="Steve’s Post Title | Steve&amp;apos;s Test Site" />
<meta property="og:site_name" content="Steve&#039;s Test Site" />
<meta name="twitter:title" content="Steve’s Post Title | Steve&amp;apos;s Test Site" />

The doc title and og:site_name are fine but the og:title and twitter:title are not.

@amostajo
Copy link
Contributor

PR:970
Can't seem to replicate issue.

698

@wpsmort
Copy link
Author

wpsmort commented Jul 28, 2017

@michaeltorbert I cannot reproduce this either. I tested back through the commits to 2.3.14.1 and 2.3.14.2 and it looks like PR #970 did fix this issue by replacing &apos; with &#039;

@michaeltorbert
Copy link
Contributor

Closing this as it was fixed in the same version that broke it, pre-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants