-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement useless gap support #80
Comments
i don't think what visual separation is useless |
Oh, I forgot to talk about the code: Done:
What's left:
|
Neat. I'd like this. |
@BenoitZugmeyer @liquiddandruff: Can you test the branch and give some feedback? Thanks |
Testing it right now. No issue spotted. I'll keep using it for a few days. If anyone is interested, here is an ArchLinux PKGBUILD |
I've spotted an issue:
The space between the clients is increasing. |
I would definitely like this to be added. Window borders are so ugly, but useless gaps provide the same separation while looking nice! I'll see if I can play around with the code a bit. |
I took a different approach which I find much simpler: silverhammermba/awesome@986e9bf My idea was to let the layout arrange the clients as usual, then perform a second pass to slightly shrink each client to create the gaps. The advantage of this method is that it involves very little code and is layout-agnostic. However, there are two issues with this approach:
I think that both of these problems could be solved by DRYing off the layout code so that each layout simply partitions the screen according to the number of clients, returns the resulting geometries, and the geometries are actually applied in |
Now that #101 is merged, useless gaps can/should be implemented based on it (silverhammermba@986e9bf). @silverhammermba |
Sure thing, but I'm stuck in the same place @Elv13 was: making the gaps not hard-coded. I feel like they should be configured similarly to border widths, but there's a surprising amount of code for handling the border width property. Any advice on how I should approach this? |
Here we are again,
For the zillion-th time, someone asked for it, so I got bored of the same feature request and hacked it. Here is the code:
Elv13@bb987e4
I need some feedback before porting this to master and doing a proper PR.
It seem to work fine. Is it useful: no. Does it look nice: maybe. Will I recommend anyone using that: no
The text was updated successfully, but these errors were encountered: