Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetNews view adds more articles when hitting search repeatedly #134

Closed
gursi26 opened this issue Nov 27, 2023 · 1 comment · Fixed by #139
Closed

GetNews view adds more articles when hitting search repeatedly #134

gursi26 opened this issue Nov 27, 2023 · 1 comment · Fixed by #139
Assignees

Comments

@gursi26
Copy link
Collaborator

gursi26 commented Nov 27, 2023

As title says. To reproduce, do the following;

  1. Go to the get news view
  2. Enter a search term
  3. Hit the search button multiple times

The number of articles increases without a reset.

@quiz3
Copy link
Collaborator

quiz3 commented Nov 27, 2023

To resolve this, I believe I will need to modify the propertyChanged method of GetNewsView and make it so that the pane is reset each time the property changes in a way that would add more news.

@quiz3 quiz3 linked a pull request Nov 27, 2023 that will close this issue
@quiz3 quiz3 closed this as completed Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants