You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Yeah, I was actually thinking about this again recently. I opened PyO3 PR 1406 awhile back to get my thoughts on it out there. The main issue I had with it at the time was that it would have been a bit weird to provide tokio specific or async-std specific stuff in the PyO3 core.
Moving that #[pyfunction] proc macro here would have been a lot of duplicated code and more than I wanted to maintain, but if we can instead delegate to #[pyfunction] from our own runtime-specific proc macro like you've laid out, then I think it would work better.
I think we can do something like this in the proc macro:
To me, the current examples look very verbose for what they eventually do;
To me, this looks easily collapsible into something like this;
This would be a little bit more ergonomic to write.
The text was updated successfully, but these errors were encountered: