Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract book for testing #67

Closed
awfm9 opened this issue Jan 9, 2018 · 1 comment
Closed

Abstract book for testing #67

awfm9 opened this issue Jan 9, 2018 · 1 comment

Comments

@awfm9
Copy link
Owner

awfm9 commented Jan 9, 2018

After moving book back into the network package, testing has become harder because it is now a hard dependency. It would be good to abstract all events that can happen in a handler as its own interface, and inject two interfaces into the handler on start.

Each handler at that point has: log, waitgroup, config, dependencies, events. I would love it if we could abstract the first three into dependencies, but that would be a bit too convoluted of an interface I believe. Go is just not made for this kind of functional programming.

@awfm9
Copy link
Owner Author

awfm9 commented Jan 10, 2018

Has been done in #71

@awfm9 awfm9 closed this as completed Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant