-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GlobalStatsStream does not track all instances after update to Node v12.16.0 #120
Comments
Hi @stefanpernpaintner thanks for raising this issue. I'm not aware of any issues with newer version of node. Do you see the same issue with other major versions of node such as 14 or 15? |
I've tested only with node 14. The issue exists with node 14 too. |
Here is a full example with express which shows that only "Brake 1" is considered by the stream if you run it on node > 12.16 :
|
The root cause of problem is after first snapshot is processed by _rawStream. The stream gets paused and cannot pass check in main/lib/globalStats.js#L54 . Therefore, it will not able to push anymore snapshots in the stream for newer versions of Node. Please see https://nodejs.org/api/stream.html#stream_compatibility_with_older_node_js_versions . I created a pull request #121 with a fix. |
This issue should be fixed in in version 3.1.0. Thank you @UyumazHakan for the collaboration. |
Brakes version: 3.0.1
After having updated to Node v12.16.0 globalStatsStream does not track the instances correctly. I have two brakes instantiated but only the first brake does notify via stream for only one first event. Example:
With Node v12.15.0 it is working as expected. Alle events are propagated via the stats stream. Any known issues about this?
The text was updated successfully, but these errors were encountered: