Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): Fix for missing session variable when custom auth is performed #2335

Merged
merged 6 commits into from
Mar 16, 2023

Conversation

gpanshu
Copy link
Contributor

@gpanshu gpanshu commented Mar 15, 2023

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gpanshu gpanshu requested a review from a team as a code owner March 15, 2023 15:51
tjleing
tjleing previously approved these changes Mar 15, 2023
tylerjroach
tylerjroach previously approved these changes Mar 15, 2023
@gpanshu gpanshu dismissed stale reviews from tylerjroach and tjleing via 0bfb706 March 15, 2023 16:03
tjleing
tjleing previously approved these changes Mar 15, 2023
@gpanshu gpanshu changed the title fix(auth): Fix for missing session variable when custom auth with srp is performed fix(auth): Fix for missing session variable when custom auth is performed Mar 15, 2023
@gpanshu gpanshu enabled auto-merge (squash) March 16, 2023 14:05
@gpanshu gpanshu merged commit 121dfca into main Mar 16, 2023
@gpanshu gpanshu deleted the fix-customauthwithsrp branch March 16, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants