Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use better fallback for list query v2 #2344

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Conversation

tjleing
Copy link
Contributor

@tjleing tjleing commented Mar 18, 2023

Compare to Swift version of this file

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tjleing tjleing changed the title Use better fallback for list query -- needs doublechecking for why th… Use better fallback for list query v2 Mar 18, 2023
@tjleing tjleing marked this pull request as ready for review March 23, 2023 17:33
@tjleing tjleing requested a review from a team as a code owner March 23, 2023 17:34
tylerjroach
tylerjroach previously approved these changes Mar 24, 2023
@tjleing tjleing merged commit 5935528 into main Mar 27, 2023
@tjleing tjleing deleted the leint/fix-list-plural-name-v2 branch March 27, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants