Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (push): also catch RuntimeExecutionException for google play store device use case #2562

Merged
merged 5 commits into from
Aug 21, 2023

Conversation

tjleing
Copy link
Contributor

@tjleing tjleing commented Aug 17, 2023

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:
#2555 and #2559

Description of changes:

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tjleing tjleing requested a review from a team as a code owner August 17, 2023 16:32
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2023

Codecov Report

Merging #2562 (5904977) into main (62164bd) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2562      +/-   ##
==========================================
- Coverage   41.18%   41.16%   -0.02%     
==========================================
  Files         873      873              
  Lines       27620    27620              
  Branches     3878     3878              
==========================================
- Hits        11375    11371       -4     
- Misses      15026    15029       +3     
- Partials     1219     1220       +1     

tylerjroach
tylerjroach previously approved these changes Aug 17, 2023
ankpshah
ankpshah previously approved these changes Aug 17, 2023
@tjleing tjleing dismissed stale reviews from ankpshah and tylerjroach via d31bd5f August 18, 2023 18:04
mattcreaser
mattcreaser previously approved these changes Aug 18, 2023
ankpshah
ankpshah previously approved these changes Aug 18, 2023
@tjleing tjleing enabled auto-merge (squash) August 18, 2023 18:09
@tjleing tjleing dismissed stale reviews from ankpshah and mattcreaser via 5904977 August 18, 2023 21:48
@tjleing tjleing merged commit 6b4f31a into main Aug 21, 2023
6 checks passed
@tjleing tjleing deleted the push-catch-more-exceptions branch August 21, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants