Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): Fix for missing exception type for sign in #2567

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

gpanshu
Copy link
Contributor

@gpanshu gpanshu commented Aug 22, 2023

  • PR title and description conform to Pull Request guidelines.

Issue #, if available: #2523

Description of changes: UserLambda exception was not present in the converter and instead we were sending an unknown exception back to the customer. This fixes that.

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gpanshu gpanshu requested a review from a team as a code owner August 22, 2023 16:10
@gpanshu gpanshu enabled auto-merge (squash) August 22, 2023 16:31
@gpanshu gpanshu merged commit be07335 into main Aug 22, 2023
4 checks passed
@gpanshu gpanshu deleted the fix-missing-exception branch August 22, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants