fix(auth): Fix for when alias is used to sign in and deviceKey is stored with the entered username instead of retrieved username #2614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 23, 2023
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #2614 +/- ##
==========================================
- Coverage 41.71% 41.71% -0.01%
==========================================
Files 900 900
Lines 28852 28865 +13
Branches 4098 4104 +6
==========================================
+ Hits 12037 12040 +3
- Misses 15491 15497 +6
- Partials 1324 1328 +4 |
tylerjroach
approved these changes
Oct 23, 2023
aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/helpers/AuthHelper.kt
Show resolved
Hide resolved
tylerjroach
reviewed
Oct 23, 2023
aws-auth-cognito/src/main/java/com/amplifyframework/auth/cognito/actions/SRPCognitoActions.kt
Outdated
Show resolved
Hide resolved
tylerjroach
requested changes
Oct 23, 2023
tylerjroach
approved these changes
Oct 24, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #2609
Description of changes:
When a user signs in with their alias instead of a username and the userpool is not configured to sign in with username, cognito assigns a username to that user (generally a generated UUID). However this breaks the current flow in a way that device ID gets generated each time as there is no stored device information for the new generated username for when we have to do respondToAuthChallenge we use the username returned from the service and not the username that was entered by the user.
This PR will fix that flow for Custom Auth (with/without SRP and SRP).
Important to note:
This fix does not fix device tracking for when AuthFlow is
USER_PASSWORD_AUTHas InitiateAuth in user_password_auth does not have access to deviceTracking.How did you test these changes?
(Please add a line here how the changes were tested)
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.