chore: prevent cold pkg start by warming binary immediately after installation #10139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhockett
approved these changes
Apr 5, 2022
edwardfoyle
approved these changes
Apr 5, 2022
danielleadams
pushed a commit
that referenced
this pull request
Apr 8, 2022
…ation (#10139) The first invocation of the amplify binary takes several seconds on Mac and Windows OSs. This commit moves the first invocation into the postinstall script so that the customer's manual CLI invocation feels snappy. BREAKING CHANGE: to make sure lerna does the right thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The first invocation of the
amplifybinary takes several seconds on Mac and Windows OSs. This commit moves the first invocation into the postinstall script so that the customer's manual CLI invocation feels snappy.Issue #, if available
n/a
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.