Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed unsupported portfinder #10269

Merged

Conversation

ammarkarachi
Copy link
Contributor

@ammarkarachi ammarkarachi commented Apr 22, 2022

Description of changes

Removed unsupported portfinder and replaced by get-port. Webpack-dev-server still hasn't

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ammarkarachi ammarkarachi requested a review from a team as a code owner April 22, 2022 16:44
@codecov-commenter
Copy link

Codecov Report

Merging #10269 (95ba1bd) into master (eff77da) will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master   #10269   +/-   ##
=======================================
  Coverage   54.28%   54.28%           
=======================================
  Files         850      850           
  Lines       46956    46956           
  Branches    10005    10005           
=======================================
  Hits        25490    25490           
  Misses      19448    19448           
  Partials     2018     2018           
Impacted Files Coverage Δ
...ages/amplify-appsync-simulator/src/server/index.ts 93.93% <66.66%> (ø)
...plify-appsync-simulator/src/server/subscription.ts 39.83% <66.66%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@johnpc johnpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for webpack-dev-server but otherwise lgtm

Copy link
Contributor

@sachscode sachscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ammarkarachi
Copy link
Contributor Author

I will merge this and create another PR for Webpack

@ammarkarachi ammarkarachi merged commit 33d8a8f into aws-amplify:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants