Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function: Migrate from aws-serverless-express to serverless-express #10812

Open
2 tasks
ghost opened this issue Jul 27, 2022 · 2 comments
Open
2 tasks

function: Migrate from aws-serverless-express to serverless-express #10812

ghost opened this issue Jul 27, 2022 · 2 comments
Labels
bug Something isn't working functions Issues tied to the functions category good first issue Good for newcomers p3

Comments

@ghost
Copy link

ghost commented Jul 27, 2022

Is this feature request related to a new or existing Amplify category?

function

Is this related to another service?

No response

Describe the feature you'd like to request

'amplify add function' will produce lambda code that utilizes aws-serverless-express.

npmjs indicates that this library is moving to @vendia/serverless-express.

I now see that aws-serverless-express is proxied to @vendia/serverless-express 3.x

It would seem prudent that 'amplify add function' at a minimum be upgraded to utilize @vendia/serverless-express 4.x (see upgrade).

Describe the solution you'd like

'amplify add function' will produce lambda code that utilizes @vendia/serverless-express preferably version 4.x.

Describe alternatives you've considered

n/a

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request

Would this feature include a breaking change?

  • ⚠️ This feature might incur a breaking change
@ykethan
Copy link
Contributor

ykethan commented Jul 27, 2022

Hello @pull-task-dev, thank you for the information. Marking this as feature request for improvements.

@ykethan ykethan added functions Issues tied to the functions category feature-request Request a new feature labels Jul 27, 2022
@josefaidt josefaidt added the p3 label Jul 27, 2022
@josefaidt josefaidt added bug Something isn't working and removed feature-request Request a new feature labels May 19, 2023
@chrisl777
Copy link

Is there decent support from @vendia/serverless-express? I see a bunch of open issues on that repository without resolution. I also see some very stale PRs. I'm a bit nervous to adopt it if they don't support it well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working functions Issues tied to the functions category good first issue Good for newcomers p3
Projects
None yet
Development

No branches or pull requests

3 participants