New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth Trigger Template still uses Node 12 #10887
Comments
Hey @SebastianStamm 👋 thanks for raising this! While I was not able to see the Node 12.x runtime version be applied to a few of the auth triggers I added to my sample auth resource, I do think this is a great callout and should be updated. Perhaps we can also consider bumping to Node 16 across all functions. Marking as a bug 🙂 |
It nice to see the PR #10890 to fix this. I was going to comment re @josefaidt's idea of considering Node 16 in case anyone else reviews this issue. The current CDK sdk behind the cli and dependent https://github.com/aws-amplify/amplify-category-api only go to node 14. I attempted to do a slightly heavier lift to 1.168.0 but ran into some test breakage on amplify-category-api and just dropped the effort due to timeboxing. just an FYI why node 16 is "harder". |
Related - aws-amplify/amplify-studio#639 |
AWS notification e-mail recommends to migrate from NodeJS 12 to NodeJS 16. |
Is this feature request related to a new or existing Amplify category?
auth
Is this related to another service?
Lambda
Describe the feature you'd like to request
With Node 12 being EOL, the runtime for the auth trigger function should be updated to Node 14 to be consistent with the runtime used in other environments. It currently still uses Node 12:
amplify-cli/packages/amplify-category-auth/src/provider-utils/awscloudformation/utils/generate-auth-trigger-template.ts
Line 91 in aaf2210
Describe the solution you'd like
Simply updating to
lambda.Runtime.NODEJS_14_X
should do the trick.Describe alternatives you've considered
Additional context
No response
Is this something that you'd be interested in working on?
Would this feature include a breaking change?
The text was updated successfully, but these errors were encountered: