fix: trigger analytics migration on update/configure notifications #11285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolk
reviewed
Oct 28, 2022
| @@ -5,7 +5,7 @@ import { invokeAnalyticsMigrations } from '../plugin-client-api-analytics'; | |||
| * checks if the project has been migrated to the latest version | |||
| */ | |||
| export const migrationCheck = async (context: $TSContext): Promise<void> => { | |||
| if (['add', 'update', 'push'].includes(context.input.command)) { | |||
| if (['add', 'configure', 'push'].includes(context.input.command)) { | |||
There was a problem hiding this comment.
would it make sense to keep update in case of alias evolves to something different?
akshbhu
approved these changes
Oct 28, 2022
sobolk
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
updatecommand is just an alias, the migration check should look forconfigureDescription of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.