fix: @typescript-eslint/no-floating-promises #11665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolk
previously approved these changes
Dec 27, 2022
|
please run e2e. |
Codecov Report
@@ Coverage Diff @@
## dev #11665 +/- ##
==========================================
- Coverage 50.22% 50.21% -0.02%
==========================================
Files 705 705
Lines 34072 34083 +11
Branches 6993 7001 +8
==========================================
+ Hits 17114 17116 +2
- Misses 15478 15486 +8
- Partials 1480 1481 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Amplifiyer
approved these changes
Dec 27, 2022
sobolk
approved these changes
Dec 28, 2022
evcodes
reviewed
Dec 29, 2022
Comment on lines
+273
to
+280
| do { | ||
| const { value, done: doneResult } = await asyncIterator.next(); | ||
| done = doneResult; | ||
| if (done) { | ||
| break; | ||
| } | ||
| this.sendMessage(connectionContext, id, MESSAGE_TYPES.GQL_DATA, value); | ||
| } | ||
| } while (!done); |
There was a problem hiding this comment.
I don't know if we should use a do-while loop pattern in this case. The previous way seems cleaner and there's not many other do-while loops in our codebase
evcodes
reviewed
Dec 29, 2022
| import { | ||
| addMapResource, addMapResourceHeadless, removeMapResource, updateMapResource, updateMapResourceHeadless, | ||
| } from './map'; | ||
| import { addMapResource, addMapResourceHeadless, removeMapResource, updateMapResource, updateMapResourceHeadless } from './map'; |
There was a problem hiding this comment.
how come the imports in this file aren't separated by new lines?
evcodes
reviewed
Dec 29, 2022
| invokeAnalyticsAPIGetResources, | ||
| invokeAnalyticsPush, | ||
| } from './plugin-client-api-analytics'; | ||
| import { invokeAnalyticsAPICreateResource, invokeAnalyticsAPIGetResources, invokeAnalyticsPush } from './plugin-client-api-analytics'; |
evcodes
reviewed
Dec 29, 2022
| stack: deepestException.stack ?? 'undefined error stack', | ||
| })), | ||
| () => | ||
| executeHooks( |
There was a problem hiding this comment.
I think this should be async/awaited?
evcodes
reviewed
Dec 29, 2022
Comment on lines
+436
to
+438
| resources.concat(resourcesToBeDeleted).filter((r: { service: string }) => r.service === AmplifySupportedService.LAMBDA_LAYER).length > | ||
| 0 | ||
| ) { |
There was a problem hiding this comment.
This formatting is a bit weird
evcodes
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.