Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notification channel enabled check #11879

Merged
merged 1 commit into from
Feb 1, 2023
Merged

fix: notification channel enabled check #11879

merged 1 commit into from
Feb 1, 2023

Conversation

lazpavel
Copy link
Contributor

Description of changes

  • fix notification channel enabled check

Issue #11870

Description of how you validated changes

  • manual tests
  • added unit test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lazpavel lazpavel requested a review from a team as a code owner January 31, 2023 21:40
@josefaidt josefaidt linked an issue Jan 31, 2023 that may be closed by this pull request
&& channelName in notificationsResourceMeta.output
&& notificationsResourceMeta.output[channelName].Enabled;
export const isNotificationChannelEnabled = (notificationsResourceMeta: INotificationsResourceMeta, channelName: string): boolean =>
!!notificationsResourceMeta?.output[channelName]?.Enabled;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change in this file

Copy link
Contributor

@evcodes evcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evcodes evcodes merged commit d7c51f2 into aws-amplify:dev Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error enabling FCM channel
3 participants