fix: improved typing for $TSContext #11962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sobolk
reviewed
Feb 10, 2023
sdstolworthy
force-pushed
the
tscontext-typing
branch
from
d37715b
to
6caf178
Compare
sdstolworthy
commented
Feb 13, 2023
sdstolworthy
force-pushed
the
tscontext-typing
branch
from
6942755
to
fc34cc9
Compare
sdstolworthy
changed the title
sobolk
reviewed
Feb 16, 2023
...sts__/provider-utils/awscloudformation/auth-stack-builder/auth-cognito-stack-builder.test.ts
Outdated
Show resolved
Hide resolved
...egory-auth/src/__tests__/provider-utils/awscloudformation/handlers/resource-handlers.test.ts
Outdated
Show resolved
Hide resolved
This reverts commit 5c3b053.
jhockett
reviewed
Feb 16, 2023
...ategory-auth/src/provider-utils/awscloudformation/auth-stack-builder/auth-stack-transform.ts
Show resolved
Hide resolved
edwardfoyle
reviewed
Feb 16, 2023
...sts__/provider-utils/awscloudformation/auth-stack-builder/auth-cognito-stack-builder.test.ts
Outdated
Show resolved
Hide resolved
Comment on lines
191
to
213
| command: string; | ||
| subCommands?: string[]; | ||
| options?: { | ||
| restore?: boolean; | ||
| json?: boolean; | ||
| name?: string; | ||
| awsInfo?: string; | ||
| config?: string; | ||
| 'iterative-rollback'?: boolean; | ||
| force?: boolean; | ||
| env?: string; | ||
| rootStackName?: string; | ||
| frontend?: string; | ||
| quickstart?: boolean; | ||
| app?: string | boolean; | ||
| timeout?: string; | ||
| event?: string; | ||
| minify?: boolean; | ||
| help?: boolean; | ||
| localEnvFilePath?: string; | ||
| yes?: boolean; | ||
| appId?: string; | ||
| } & Record<string, string | boolean>; |
There was a problem hiding this comment.
Another vote in favor of defining this type as Record<string, string | boolean>
packages/amplify-cli/src/domain/amplify-usageData/UsageDataPayload.ts
Outdated
Show resolved
Hide resolved
packages/amplify-provider-awscloudformation/src/configuration-manager.ts
Show resolved
Hide resolved
jhockett
previously approved these changes
Feb 17, 2023
Amplifiyer
approved these changes
Feb 17, 2023
sobolk
approved these changes
Feb 17, 2023
jhockett
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds additional typing for $TSContext.
As a general rule, types were not renamed unless there was a logical conflict or additional clarity was needed.
All types/interfaces used to define $TSContext were moved into
amplify-cli-core.In many cases across the codebase, nullable values are treated as non-nullable. In cases where this occurred, the type was defined as nullable, and null checks were added where needed. In cases where non-null assertions were removed and a null value would throw a type error in the existing code, a null check is added that specifically throws a type error.
Where possible, types and interfaces were moved to
amplify-cli-core, and implementers are left inamplify-cli(or-auth).Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.