fix: await pinpoint response #11993
Merged
fix: await pinpoint response #11993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhockett
approved these changes
Feb 13, 2023
sobolk
approved these changes
Feb 13, 2023
| @@ -63,24 +61,23 @@ export const enable = async (context: $TSContext, successMessage: string | undef | |||
|
|
|||
| spinner.start('Enabling FCM channel.'); | |||
| try { | |||
| const data = context.exeInfo.pinpointClient.updateGcmChannel(params).promise(); | |||
| const data = await context.exeInfo.pinpointClient.updateGcmChannel(params).promise(); | |||
There was a problem hiding this comment.
didn't linter catch this for some reason ?
There was a problem hiding this comment.
pinpoint client isn't typed. I found this while trying to add types to exeInfo. The linter couldn't catch this because it doesn't know the type of pinpointClient.
There was a problem hiding this comment.
But to better answer the question, yes. The typescript ESLint plugin will flag unhandled promises.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This awaits a previously unawaited call to the pinpoint sdk.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.