fix: update pinpoint regions #12379
Merged
fix: update pinpoint regions #12379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolk
previously approved these changes
Apr 4, 2023
Amplifiyer
reviewed
Apr 4, 2023
|
@Amplifiyer, from the standpoint of the pinpoint resource, we cannot update the existing one so a push will still keep the pinpoint resource from us-east-1 even after update, there are problems trying to add notifications channels as we use the mapping logic to build the pinpoint client instead of getting the region from the pinpoint resource which in turn fails with |
|
We should test and get this merged as well as part of this PR |
sobolk
previously approved these changes
Apr 12, 2023
| @@ -11,20 +11,32 @@ import { | |||
| $TSMeta, | |||
| AmplifyError, | |||
| AmplifyFault, | |||
| FeatureFlags, | |||
Amplifiyer
previously approved these changes
Apr 12, 2023
Comment on lines
+548
to
+554
| if (httpProxy) { | ||
| aws.config.update({ | ||
| httpOptions: { | ||
| agent: proxyAgent(httpProxy), | ||
| }, | ||
| }); | ||
| } |
There was a problem hiding this comment.
Can you leave a comment here on why http proxy was provided by the user? Any reference to public documentation will help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.