fix: set policy effect deny when removing auth #13523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardfoyle
force-pushed
the
deny-hotfix
branch
from
0a3f35f
to
5146acc
Compare
sobolk
approved these changes
Jan 9, 2024
edwardfoyle
added a commit
that referenced
this pull request
Jan 10, 2024
* fix: set policy effect deny when removing auth * fix: set policy effect deny when removing auth (#13523) * chore(release): Publish latest - @aws-amplify/amplify-category-notifications@2.26.12 - @aws-amplify/cli@12.10.1 - @aws-amplify/cli-internal@12.10.1 - @aws-amplify/amplify-provider-awscloudformation@8.10.2 - @aws-amplify/amplify-util-mock@5.9.2 --------- Co-authored-by: aws-amplify-bot <aws@amazon.com>
6 tasks
sobolk
added a commit
that referenced
this pull request
Feb 21, 2024
…13604) * fix: set policy effect deny when removing auth (#13523) * chore(release): Publish latest - @aws-amplify/amplify-category-notifications@2.26.12 - @aws-amplify/cli@12.10.1 - @aws-amplify/cli-internal@12.10.1 - @aws-amplify/amplify-provider-awscloudformation@8.10.2 - @aws-amplify/amplify-util-mock@5.9.2 * chore: remove v10 migration tests * chore: remove some v8 migration tests * chore: remove some v8 migration tests * restore that --------- Co-authored-by: Edward Foyle <foyleef@amazon.com> Co-authored-by: aws-amplify-bot <aws@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When auth is removed, set the auth and unauth role policies to deny
Issue #, if available
Description of how you validated changes
Manually verified with a local deployment. Existing tests are passing (yet to run e2e). We can write an e2e test for this, but want to get the fix out first.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.