Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(amplify-frontend-ios): update amplify-xcode integration #13616

Merged
merged 2 commits into from Mar 5, 2024
Merged

feat(amplify-frontend-ios): update amplify-xcode integration #13616

merged 2 commits into from Mar 5, 2024

Conversation

harsh62
Copy link
Member

@harsh62 harsh62 commented Feb 23, 2024 •
edited

Description of changes

The issue is aimed at updating the binary of amplify-xcode which has included some fixes. For more information about the fixes, please refer aws-amplify/amplify-swift#3536.

Issue #, if available

aws-amplify/amplify-swift#3307 , aws-amplify/amplify-swift#3139

Description of how you validated changes

Unit tested amplify-xcode and manual tests were run. Please refer the amplify swift PR.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harsh62 harsh62 requested a review from a team as a code owner February 23, 2024 20:38
@harsh62 harsh62 added platform-init Issues related to initializing a new Amplify project first-time-contributor The contribution is the first for this user in the repo platform-pull Issues related to `amplify pull` and removed platform-init Issues related to initializing a new Amplify project labels Feb 23, 2024
@harsh62 harsh62 mentioned this pull request Feb 27, 2024
Closed
2 tasks
@sobolk sobolk merged commit 46c6334 into dev Mar 5, 2024
5 checks passed
@sobolk sobolk deleted the fix/update-amplify-xcdoe branch March 5, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpilch dpilch dpilch approved these changes

@sobolk sobolk sobolk approved these changes

Assignees
No one assigned
Labels
first-time-contributor The contribution is the first for this user in the repo platform-pull Issues related to `amplify pull`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harsh62 @dpilch @sobolk