Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amplify-category-auth): added pagination for listGroups api action #13723

Merged

Conversation

muvashi
Copy link
Contributor

@muvashi muvashi commented Apr 17, 2024

Description of changes

Added pagination for listGroups admin api action. Cognito listGroups API returns nextToken not PaginationToken.

Ref :- https://docs.aws.amazon.com/cognito-user-identity-pools/latest/APIReference/API_ListGroups.html

Issue #, if available

#13722

Description of how you validated changes

Lambda code :-
Lambda_code

Results :-
Results

Checklist

  • [Y] PR description included
  • [Y ] yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@muvashi muvashi requested a review from a team as a code owner April 17, 2024 21:20
Copy link
Member

@sobolk sobolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good.

How did you verify the change?
If manually, please attach some evidence (screenshots or logs) in PR description.

@muvashi
Copy link
Contributor Author

muvashi commented Apr 17, 2024

Hello sobolk, Thanks for taking a look.

Updated the description with evidence.

Copy link
Contributor

@bombguy bombguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolk sobolk merged commit 0d52c47 into aws-amplify:dev Apr 17, 2024
5 checks passed
@muvashi muvashi deleted the category-auth/admin-auth-cognitoActions branch April 19, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants