fix: update pinpoint IAM policy to use mobiletargeting instead of mobileanalytics #326
Conversation
kaustavghosh06
requested review from
mlabieniec,
UnleashedMind and
powerful23
ghost
assigned 
| @@ -96,7 +96,7 @@ function getPolicyDoc(context) { | |||
| { | |||
| Effect: 'Allow', | |||
| Action: [ | |||
| 'mobileanalytics:PutEvents', | |||
| 'mobiletargeting:PutEvents', | |||
There was a problem hiding this comment.
Shouldn't move this line to be next to line 108?
There was a problem hiding this comment.
Agreed. Those are copied over from the old implementations, but I think it does make sense to combine both in a single policy statement and restrict the putEvents action to only the specific pinpoint project.
There was a problem hiding this comment.
We can combine the policy statements as suggested by @powerful23
| @@ -96,7 +96,7 @@ function getPolicyDoc(context) { | |||
| { | |||
| Effect: 'Allow', | |||
| Action: [ | |||
| 'mobileanalytics:PutEvents', | |||
| 'mobiletargeting:PutEvents', | |||
There was a problem hiding this comment.
Agreed. Those are copied over from the old implementations, but I think it does make sense to combine both in a single policy statement and restrict the putEvents action to only the specific pinpoint project.
* upstream-master: fix: update pinpoint IAM policy to use mobiletargeting instead of mobileanalytics (aws-amplify#326) Update native_guide.md
* upstream-master: (125 commits) fix: update pinpoint IAM policy to use mobiletargeting instead of mobileanalytics (aws-amplify#326) Update native_guide.md Fixing aws-amplify#183 (aws-amplify#285) Initial work on @http directive (aws-amplify#255) Add option/flag in amplify push command to not automatically re-compile annotated GraphQL schema (aws-amplify#328) chore(release): Publish [ci skip] chore(release): Publish [ci skip] ci: run integration tests before release ci: merge release branch after publishing Update Readme.md (aws-amplify#324) Update Readme.md (aws-amplify#323) Update native_guide.md (aws-amplify#321) updating cypress test for auth message updating cypress test for auth1 updating cypress test for auth running graphql integration tests only for merged PRs fixes(aws-amplify#303) fix frontend config fix(graphql-auth-transformer): Modifies the name of the user pool resource Fixing integration tests & moving amplify init to seperate expect script (aws-amplify#291) ...
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Description of changes:
Due to a recent change with Pinpoint API's, IAM policies need to be changed for the newly created Pinpoint API's. This PR modifies the IAM policies generated for a pinpoint endpoint using the CLI.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.