multienv support for Notifications #440
Conversation
ghost
assigned 
| await multiEnvManager.initEnv(context); | ||
| } | ||
|
|
||
| async function initEnvPush(context) { |
There was a problem hiding this comment.
What is initEnvPush? When is this called?
| @@ -52,6 +50,8 @@ async function initializeEnv(context) { | |||
|
|
|||
| spinner.start(`Initializing your environment: ${currentEnv}`); | |||
| await sequential(initializationTasks); | |||
| spinner.succeed('Initialized your environment successfully.'); | |||
There was a problem hiding this comment.
Initialized provider successfully. Since the complete initialization is not done until the initEnv() of all the categories are called. Probably should add context.print.success('Initialized your environment successfully.') after category initialization is done.
| @@ -65,6 +65,7 @@ async function initializeEnv(context) { | |||
| } | |||
| // Generate AWS exports/configurtion file | |||
| context.amplify.onCategoryOutputsChange(context); | |||
| spinner.succeed('Initialized your environment successfully.'); | |||
There was a problem hiding this comment.
This should be context.print.success() and not spinner.succeed.
| @@ -65,7 +68,7 @@ async function initializeEnv(context) { | |||
| } | |||
| // Generate AWS exports/configurtion file | |||
| context.amplify.onCategoryOutputsChange(context); | |||
| spinner.succeed('Initialized your environment successfully.'); | |||
| context.print.info('Initialized your environment successfully.'); | |||
There was a problem hiding this comment.
context.print.success
* resolve env config issue * minor fix * through lint * minor fix * add multienv support for hosting * minor fix * work in progressg * work in progress * work in progress * work in progress * move write amplify meta into the multi-env-manager * insert pull methods for the channels * work in progress * work in progess * through lint * minor fix * add categories input params * work in progress * add input params to channel enable logic * add input params validation for the channels * through lint * work in progress * work in progress * through lint * through lint * work in progress * minor fix * through push * tested with issue fixes * through lint * fix tests * changes per reivew comments * changes per review request * changes per review request
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.