perf: fulfill promises to upload files to S3 concurrently

[nchaloult]

Issue #, if available:
#4158

Description of changes:
When uploading multiple files to S3 after running $ amplify publish, those uploads are handled one after the other when they could be handled concurrently. Rather than fulfilling promises to upload each file sequentially, this PR proposes that we let the node runtime handle fulfilling those promises concurrently with Promise.all().

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[nchaloult]

It looks like the original member of the open source community who created #4158 opened a PR of their own to resolve this issue: #4508. After taking a look at it, I'm not sure if their work is correct. I'd like to hear what everyone else thinks.

uploadFileTasks is an array of anonymous functions that return promises, because sequential() expects an array of functions that return promises as its argument. Promise.all(), however, expects an iterable of promises as its argument, so the logic that builds the items in the uploadFileTasks array needs to be changed accordingly if sequential() is to be swapped out for Promise.all().

I confirmed through local testing with amplify-dev that if sequential() call is replaced with Promise.all(), but no changes are made to the way that the uploadFileTasks array is constructed, no files are ever uploaded to an S3 bucket.

[codecov]

Codecov Report

Merging #4575 into master will decrease coverage by 0.52%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           master    #4575      +/-   ##
==========================================
- Coverage   61.57%   61.04%   -0.53%     
==========================================
  Files         333      333              
  Lines       14550    14704     +154     
  Branches     2764     2782      +18     
==========================================
+ Hits         8959     8976      +17     
- Misses       5164     5299     +135     
- Partials      427      429       +2     

Impacted Files	Coverage Δ
...s/awscloudformation/utils/trigger-file-uploader.js	17.94% <0.00%> (ø)
...ejs-function-runtime-provider/src/utils/execute.ts	75.47% <50.00%> (-0.46%)	⬇️
...aphql-auth-transformer/src/ModelAuthTransformer.ts	87.96% <50.00%> (+0.10%)	⬆️
...sting/lib/S3AndCloudFront/helpers/file-uploader.js	77.55% <100.00%> (-0.89%)	⬇️
...-model-plugin/src/visitors/appsync-java-visitor.ts	90.75% <100.00%> (+0.16%)	⬆️
packages/graphql-transformer-core/src/index.ts	96.77% <100.00%> (-0.20%)	⬇️
...ackages/graphql-transformer-core/src/validation.ts	97.67% <100.00%> (ø)
...kages/amplify-util-mock/src/utils/lambda/invoke.ts
...kages/amplify-util-mock/src/__e2e__/utils/index.ts
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c04c28...37333cf. Read the comment docs.

[GeorgeBellTMH]

I am fine with closing my PR...it wasn't working, and I have had other stuff on my plate...

[github-actions]

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.