feat: add check for extra command line args provided with amplify delete

[nchaloult]

Issue #, if available:
#4115

Description of changes:
Since $ amplify delete is a sensitive and dangerous command, there should be checks in place to ensure that users truly mean to execute it. $ amplify delete may be confused with $ amplify remove <category>. If $ amplify delete is executed with any additional command line arguments, then an error message should be displayed indicating that the delete command does not accept any arguments, and a suggestion should be printed that asks the user if they meant to use the remove command instead of delete.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov]

Codecov Report

Merging #4576 into master will increase coverage by 0.12%.
The diff coverage is 80.95%.

@@            Coverage Diff             @@
##           master    #4576      +/-   ##
==========================================
+ Coverage   61.57%   61.69%   +0.12%     
==========================================
  Files         333      332       -1     
  Lines       14550    14534      -16     
  Branches     2764     2929     +165     
==========================================
+ Hits         8959     8967       +8     
+ Misses       5164     5126      -38     
- Partials      427      441      +14     

Impacted Files	Coverage Δ
...ejs-function-runtime-provider/src/utils/execute.ts	75.47% <50.00%> (-0.46%)	⬇️
...aphql-auth-transformer/src/ModelAuthTransformer.ts	87.96% <50.00%> (+0.10%)	⬆️
packages/amplify-cli/src/commands/delete.js	100.00% <100.00%> (ø)
...-model-plugin/src/visitors/appsync-java-visitor.ts	90.75% <100.00%> (+0.16%)	⬆️
packages/graphql-transformer-core/src/index.ts	96.77% <100.00%> (-0.20%)	⬇️
...ackages/graphql-transformer-core/src/validation.ts	97.67% <100.00%> (ø)
packages/graphql-mapping-template/src/print.ts	35.71% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts	0.00% <0.00%> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts	88.09% <0.00%> (ø)
... and 19 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c04c28...e3b46d0. Read the comment docs.

[ammarkarachi]

@nchaloult We have a command to support our headless users amplify delete --force I believe this would break them

[nchaloult]

@nchaloult We have a command to support our headless users amplify delete --force I believe this would break them

I tested this locally with $ amplify-dev delete --force and $ amplify-dev delete <any-other-argument>. The delete --force command seems to behave as expected, even after the changes in this PR. I believe that's because of the first if statement in the getConfirmation() func in packages/amplify-cli/src/extensions/amplify-helpers/delete-project.js

if (context.input.options && context.input.options.force) {
  return {
    proceed: true,
    deleteS3: true,
    deleteAmpilfyApp: true,
  };
}

[nchaloult]

Are there any other situations where $ amplify delete may expect additional command line arguments?

[ammarkarachi]

Can you write a unit test that tests this change?

[nchaloult]

Can you write a unit test that tests this change?

I wrote a first draft of a set of tests.

I'm concerned about the fact that the delete.run() method calls process.exit(1) if additional command line arguments are present. I did some reading about how Jest handles situations where functions that tests call try to interrupt or kill a node process, but I'm still not sure if this will be a problem when these new tests run on this project's CI pipeline. What do you think?

[nchaloult]

Addressed the concerns with process.exit(), and moved the new test file to a new directory that the CI pipeline recognizes and runs.

[github-actions]

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.