chore: remove unnecessary stack trace log when adding services #4610

sebastiancrossa · 2020-06-18T22:31:25Z

Issue #, if available:
#4283

Description of changes:
The unnecessary stack traces that were displayed through the console when a user tried to run amplify add without initializing amplify first was because of a lacking try/catch block which displays only the error message, so I added that onto the parts where the addition of services was being called.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov · 2020-06-18T22:43:17Z

Codecov Report

Merging #4610 into master will decrease coverage by 0.02%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##           master    #4610      +/-   ##
==========================================
- Coverage   61.57%   61.55%   -0.03%     
==========================================
  Files         333      333              
  Lines       14550    14558       +8     
  Branches     2764     2932     +168     
==========================================
+ Hits         8959     8961       +2     
+ Misses       5164     5152      -12     
- Partials      427      445      +18

Impacted Files	Coverage Δ
...ejs-function-runtime-provider/src/utils/execute.ts	`75.47% <50.00%> (-0.46%)`	⬇️
...aphql-auth-transformer/src/ModelAuthTransformer.ts	`87.96% <50.00%> (+0.10%)`	⬆️
...-model-plugin/src/visitors/appsync-java-visitor.ts	`90.75% <100.00%> (+0.16%)`	⬆️
packages/graphql-transformer-core/src/index.ts	`96.77% <100.00%> (-0.20%)`	⬇️
...ackages/graphql-transformer-core/src/validation.ts	`97.67% <100.00%> (ø)`
packages/graphql-mapping-template/src/print.ts	`35.71% <0.00%> (ø)`
packages/amplify-util-mock/src/storage/storage.ts	`0.00% <0.00%> (ø)`
...ges/amplify-util-mock/src/CFNParser/stack/index.ts	`88.09% <0.00%> (ø)`
...ges/graphql-transformer-core/src/util/fileUtils.ts	`11.76% <0.00%> (ø)`
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c04c28...a5b5220. Read the comment docs.

ammarkarachi · 2020-06-22T16:29:43Z

packages/amplify-category-predictions/commands/predictions/update.js

@@ -20,7 +20,7 @@ module.exports = {
        context.print.success(`Successfully updated resource ${resourceName} locally`);
      })
      .catch(err => {
-        context.print.info(err.stack);
+        context.print.error(err.message);


This is going to swallow errors on update there is a possibility of users losing information of their errors on update of a valid project

ammarkarachi · 2020-06-22T16:30:46Z

packages/amplify-category-predictions/commands/predictions/add.js

        );
        print.info('');
      })
      .catch(err => {
-        context.print.info(err.stack);
+        context.print.error(err.message);


Same here, we still need the stack trace in case of other errors.

ammarkarachi · 2020-06-22T16:44:39Z

@sebastiancrossa
It's great that you have written tests for the amplify execute command but the way to go about it would be to have the smallest impact to change the current functionality.

If the project is not an amplify project any other command that does not initialize, configure or pull an existing project should result in an error/information without a stack trace. Refer to docs for more information.
amplify pull
amplify configure
amplify init

…ices (#4610)" This reverts commit 5bee574.

…ices (aws-amplify#4610)" This reverts commit 5bee574. Revert "feat: add check for extra command line args provided with amplify delete (aws-amplify#4576)" This reverts commit 82d1093. test(amplify-category-auth): fixed push test

…ices (aws-amplify#4610)" This reverts commit 5bee574.

* feat(amplify-provider-awscloudformation): add region ca-central-1 * fix test * Revert "Add region ca-central-1 (#4796)" This reverts commit c8b6bd8. * Revert "feat: add check for extra command line args provided with amplify delete (#4576)" This reverts commit 82d1093. * Revert "perf: fulfill promises to upload files to S3 concurrently (#4575)" This reverts commit 96d1914. * Revert "fix(cli): remove unnecessary stack trace log when adding services (#4610)" This reverts commit 5bee574. * Revert "fix test" This reverts commit 63c3c78. Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>

…ices (#4610)" This reverts commit 56efb32.

…s-amplify#4610)

* feat(amplify-provider-awscloudformation): add region ca-central-1 * fix test * Revert "Add region ca-central-1 (aws-amplify#4796)" This reverts commit af29f35. * Revert "feat: add check for extra command line args provided with amplify delete (aws-amplify#4576)" This reverts commit 48b27b7. * Revert "perf: fulfill promises to upload files to S3 concurrently (aws-amplify#4575)" This reverts commit 9fbee8a. * Revert "fix(cli): remove unnecessary stack trace log when adding services (aws-amplify#4610)" This reverts commit 56efb32. * Revert "fix test" This reverts commit 50a8073fbbdb56931191912938fb50f542197832. Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>

…s-amplify#4610)

* feat(amplify-provider-awscloudformation): add region ca-central-1 * fix test * Revert "Add region ca-central-1 (aws-amplify#4796)" This reverts commit af29f35. * Revert "feat: add check for extra command line args provided with amplify delete (aws-amplify#4576)" This reverts commit 48b27b7. * Revert "perf: fulfill promises to upload files to S3 concurrently (aws-amplify#4575)" This reverts commit 9fbee8a. * Revert "fix(cli): remove unnecessary stack trace log when adding services (aws-amplify#4610)" This reverts commit 56efb32. * Revert "fix test" This reverts commit 50a8073fbbdb56931191912938fb50f542197832. Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>

…s-amplify#4610)

* feat(amplify-provider-awscloudformation): add region ca-central-1 * fix test * Revert "Add region ca-central-1 (aws-amplify#4796)" This reverts commit af29f35. * Revert "feat: add check for extra command line args provided with amplify delete (aws-amplify#4576)" This reverts commit 48b27b7. * Revert "perf: fulfill promises to upload files to S3 concurrently (aws-amplify#4575)" This reverts commit 9fbee8a. * Revert "fix(cli): remove unnecessary stack trace log when adding services (aws-amplify#4610)" This reverts commit 56efb32. * Revert "fix test" This reverts commit 50a8073fbbdb56931191912938fb50f542197832. Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>

github-actions · 2021-07-10T01:44:54Z

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

sebastiancrossa added 4 commits June 12, 2020 15:25

chore: remove unnecessary stack trace log when adding services

53f27ad

feat: add tests for the executeCommand method

46af4f2

chore: specify the type for function on tests

6f68998

refactor: fixed some minor changes to the code

8e2d788

ammarkarachi self-assigned this Jun 22, 2020

ammarkarachi reviewed Jun 22, 2020

View reviewed changes

sebastiancrossa added 2 commits June 22, 2020 13:03

chore: unswallow some stack traces

e17b949

chore: add new test case to testing file

a5b5220

ammarkarachi approved these changes Jul 9, 2020

View reviewed changes

ammarkarachi merged commit 5bee574 into aws-amplify:master Jul 9, 2020

ammarkarachi added a commit that referenced this pull request Jul 10, 2020

Revert "fix(cli): remove unnecessary stack trace log when adding serv…

5ecab99

…ices (#4610)" This reverts commit 5bee574.

ammarkarachi mentioned this pull request Jul 10, 2020

Revert "chore: remove unnecessary stack trace log when adding services" #4798

Closed

UnleashedMind pushed a commit to UnleashedMind/amplify-cli that referenced this pull request Jul 10, 2020

Revert "fix(cli): remove unnecessary stack trace log when adding serv…

46ea566

…ices (aws-amplify#4610)" This reverts commit 5bee574.

ammarkarachi added a commit that referenced this pull request Jul 27, 2020

Revert "fix(cli): remove unnecessary stack trace log when adding serv…

c153eed

…ices (#4610)" This reverts commit 56efb32.

nikhname pushed a commit to nikhname/amplify-cli that referenced this pull request Jul 27, 2020

fix(cli): remove unnecessary stack trace log when adding services (aw…

56efb32

…s-amplify#4610)

sebastiancrossa added a commit to MLH-Fellowship/amplify-cli that referenced this pull request Aug 4, 2020

fix(cli): remove unnecessary stack trace log when adding services (aw…

16f8b36

…s-amplify#4610)

sebastiancrossa added a commit to MLH-Fellowship/amplify-cli that referenced this pull request Aug 25, 2020

fix(cli): remove unnecessary stack trace log when adding services (aw…

a33f124

…s-amplify#4610)

github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove unnecessary stack trace log when adding services #4610

chore: remove unnecessary stack trace log when adding services #4610

sebastiancrossa commented Jun 18, 2020

codecov bot commented Jun 18, 2020 •

edited

ammarkarachi Jun 22, 2020

ammarkarachi Jun 22, 2020

ammarkarachi commented Jun 22, 2020

github-actions bot commented Jul 10, 2021

chore: remove unnecessary stack trace log when adding services #4610

chore: remove unnecessary stack trace log when adding services #4610

Conversation

sebastiancrossa commented Jun 18, 2020

codecov bot commented Jun 18, 2020 • edited

Codecov Report

ammarkarachi Jun 22, 2020

Choose a reason for hiding this comment

ammarkarachi Jun 22, 2020

Choose a reason for hiding this comment

ammarkarachi commented Jun 22, 2020

github-actions bot commented Jul 10, 2021

codecov bot commented Jun 18, 2020 •

edited