-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add region ca-central-1 #4796
Add region ca-central-1 #4796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit c8b6bd8.
* feat(amplify-provider-awscloudformation): add region ca-central-1 * fix test * Revert "Add region ca-central-1 (#4796)" This reverts commit c8b6bd8. * Revert "feat: add check for extra command line args provided with amplify delete (#4576)" This reverts commit 82d1093. * Revert "perf: fulfill promises to upload files to S3 concurrently (#4575)" This reverts commit 96d1914. * Revert "fix(cli): remove unnecessary stack trace log when adding services (#4610)" This reverts commit 5bee574. * Revert "fix test" This reverts commit 63c3c78. Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>
* feat(amplify-provider-awscloudformation): add region ca-central-1 * fix test Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>
* feat(amplify-provider-awscloudformation): add region ca-central-1 * fix test * Revert "Add region ca-central-1 (aws-amplify#4796)" This reverts commit af29f35. * Revert "feat: add check for extra command line args provided with amplify delete (aws-amplify#4576)" This reverts commit 48b27b7. * Revert "perf: fulfill promises to upload files to S3 concurrently (aws-amplify#4575)" This reverts commit 9fbee8a. * Revert "fix(cli): remove unnecessary stack trace log when adding services (aws-amplify#4610)" This reverts commit 56efb32. * Revert "fix test" This reverts commit 50a8073fbbdb56931191912938fb50f542197832. Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>
* feat(amplify-provider-awscloudformation): add region ca-central-1 * fix test Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>
* feat(amplify-provider-awscloudformation): add region ca-central-1 * fix test * Revert "Add region ca-central-1 (aws-amplify#4796)" This reverts commit af29f35. * Revert "feat: add check for extra command line args provided with amplify delete (aws-amplify#4576)" This reverts commit 48b27b7. * Revert "perf: fulfill promises to upload files to S3 concurrently (aws-amplify#4575)" This reverts commit 9fbee8a. * Revert "fix(cli): remove unnecessary stack trace log when adding services (aws-amplify#4610)" This reverts commit 56efb32. * Revert "fix test" This reverts commit 50a8073fbbdb56931191912938fb50f542197832. Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>
* feat(amplify-provider-awscloudformation): add region ca-central-1 * fix test Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>
* feat(amplify-provider-awscloudformation): add region ca-central-1 * fix test * Revert "Add region ca-central-1 (aws-amplify#4796)" This reverts commit af29f35. * Revert "feat: add check for extra command line args provided with amplify delete (aws-amplify#4576)" This reverts commit 48b27b7. * Revert "perf: fulfill promises to upload files to S3 concurrently (aws-amplify#4575)" This reverts commit 9fbee8a. * Revert "fix(cli): remove unnecessary stack trace log when adding services (aws-amplify#4610)" This reverts commit 56efb32. * Revert "fix test" This reverts commit 50a8073fbbdb56931191912938fb50f542197832. Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.