Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region ca-central-1 #4796

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Conversation

UnleashedMind
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jhockett jhockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UnleashedMind UnleashedMind merged commit c8b6bd8 into aws-amplify:master Jul 10, 2020
UnleashedMind pushed a commit to UnleashedMind/amplify-cli that referenced this pull request Jul 10, 2020
ammarkarachi pushed a commit that referenced this pull request Jul 10, 2020
* feat(amplify-provider-awscloudformation): add region ca-central-1

* fix test

* Revert "Add region ca-central-1 (#4796)"

This reverts commit c8b6bd8.

* Revert "feat: add check for extra command line args provided with amplify delete (#4576)"

This reverts commit 82d1093.

* Revert "perf: fulfill promises to upload files to S3 concurrently (#4575)"

This reverts commit 96d1914.

* Revert "fix(cli): remove unnecessary stack trace log when adding services (#4610)"

This reverts commit 5bee574.

* Revert "fix test"

This reverts commit 63c3c78.

Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>
nikhname pushed a commit to nikhname/amplify-cli that referenced this pull request Jul 27, 2020
* feat(amplify-provider-awscloudformation): add region ca-central-1

* fix test

Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>
nikhname pushed a commit to nikhname/amplify-cli that referenced this pull request Jul 27, 2020
* feat(amplify-provider-awscloudformation): add region ca-central-1

* fix test

* Revert "Add region ca-central-1 (aws-amplify#4796)"

This reverts commit af29f35.

* Revert "feat: add check for extra command line args provided with amplify delete (aws-amplify#4576)"

This reverts commit 48b27b7.

* Revert "perf: fulfill promises to upload files to S3 concurrently (aws-amplify#4575)"

This reverts commit 9fbee8a.

* Revert "fix(cli): remove unnecessary stack trace log when adding services (aws-amplify#4610)"

This reverts commit 56efb32.

* Revert "fix test"

This reverts commit 50a8073fbbdb56931191912938fb50f542197832.

Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>
sebastiancrossa pushed a commit to MLH-Fellowship/amplify-cli that referenced this pull request Aug 4, 2020
* feat(amplify-provider-awscloudformation): add region ca-central-1

* fix test

Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>
sebastiancrossa pushed a commit to MLH-Fellowship/amplify-cli that referenced this pull request Aug 4, 2020
* feat(amplify-provider-awscloudformation): add region ca-central-1

* fix test

* Revert "Add region ca-central-1 (aws-amplify#4796)"

This reverts commit af29f35.

* Revert "feat: add check for extra command line args provided with amplify delete (aws-amplify#4576)"

This reverts commit 48b27b7.

* Revert "perf: fulfill promises to upload files to S3 concurrently (aws-amplify#4575)"

This reverts commit 9fbee8a.

* Revert "fix(cli): remove unnecessary stack trace log when adding services (aws-amplify#4610)"

This reverts commit 56efb32.

* Revert "fix test"

This reverts commit 50a8073fbbdb56931191912938fb50f542197832.

Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>
sebastiancrossa pushed a commit to MLH-Fellowship/amplify-cli that referenced this pull request Aug 25, 2020
* feat(amplify-provider-awscloudformation): add region ca-central-1

* fix test

Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>
sebastiancrossa pushed a commit to MLH-Fellowship/amplify-cli that referenced this pull request Aug 25, 2020
* feat(amplify-provider-awscloudformation): add region ca-central-1

* fix test

* Revert "Add region ca-central-1 (aws-amplify#4796)"

This reverts commit af29f35.

* Revert "feat: add check for extra command line args provided with amplify delete (aws-amplify#4576)"

This reverts commit 48b27b7.

* Revert "perf: fulfill promises to upload files to S3 concurrently (aws-amplify#4575)"

This reverts commit 9fbee8a.

* Revert "fix(cli): remove unnecessary stack trace log when adding services (aws-amplify#4610)"

This reverts commit 56efb32.

* Revert "fix test"

This reverts commit 50a8073fbbdb56931191912938fb50f542197832.

Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants