Revert problematic PRs #4803
Merged
Revert problematic PRs #4803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 10, 2020 10:01
This reverts commit c8b6bd8.
…lify delete (aws-amplify#4576)" This reverts commit 82d1093.
…s-amplify#4575)" This reverts commit 96d1914.
…ices (aws-amplify#4610)" This reverts commit 5bee574.
This reverts commit 63c3c78.
Codecov Report
@@ Coverage Diff @@
## master #4803 +/- ##
==========================================
- Coverage 61.57% 60.49% -1.08%
==========================================
Files 333 350 +17
Lines 14550 15192 +642
Branches 2764 3042 +278
==========================================
+ Hits 8959 9191 +232
- Misses 5164 5496 +332
- Partials 427 505 +78
Continue to review full report at Codecov.
|
ammarkarachi
approved these changes
Jul 10, 2020
nikhname
pushed a commit
to nikhname/amplify-cli
that referenced
this pull request
Jul 27, 2020
* feat(amplify-provider-awscloudformation): add region ca-central-1 * fix test * Revert "Add region ca-central-1 (aws-amplify#4796)" This reverts commit af29f35. * Revert "feat: add check for extra command line args provided with amplify delete (aws-amplify#4576)" This reverts commit 48b27b7. * Revert "perf: fulfill promises to upload files to S3 concurrently (aws-amplify#4575)" This reverts commit 9fbee8a. * Revert "fix(cli): remove unnecessary stack trace log when adding services (aws-amplify#4610)" This reverts commit 56efb32. * Revert "fix test" This reverts commit 50a8073fbbdb56931191912938fb50f542197832. Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>
sebastiancrossa
pushed a commit
to MLH-Fellowship/amplify-cli
that referenced
this pull request
Aug 4, 2020
* feat(amplify-provider-awscloudformation): add region ca-central-1 * fix test * Revert "Add region ca-central-1 (aws-amplify#4796)" This reverts commit af29f35. * Revert "feat: add check for extra command line args provided with amplify delete (aws-amplify#4576)" This reverts commit 48b27b7. * Revert "perf: fulfill promises to upload files to S3 concurrently (aws-amplify#4575)" This reverts commit 9fbee8a. * Revert "fix(cli): remove unnecessary stack trace log when adding services (aws-amplify#4610)" This reverts commit 56efb32. * Revert "fix test" This reverts commit 50a8073fbbdb56931191912938fb50f542197832. Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>
sebastiancrossa
pushed a commit
to MLH-Fellowship/amplify-cli
that referenced
this pull request
Aug 25, 2020
* feat(amplify-provider-awscloudformation): add region ca-central-1 * fix test * Revert "Add region ca-central-1 (aws-amplify#4796)" This reverts commit af29f35. * Revert "feat: add check for extra command line args provided with amplify delete (aws-amplify#4576)" This reverts commit 48b27b7. * Revert "perf: fulfill promises to upload files to S3 concurrently (aws-amplify#4575)" This reverts commit 9fbee8a. * Revert "fix(cli): remove unnecessary stack trace log when adding services (aws-amplify#4610)" This reverts commit 56efb32. * Revert "fix test" This reverts commit 50a8073fbbdb56931191912938fb50f542197832. Co-authored-by: UnleashedMind <zhoweimi@186590ce137f.ant.amazon.com>
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.