Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amplify-provider-awscloudformation): fix hosting output #6041

Merged
merged 1 commit into from Jan 22, 2021

Conversation

UnleashedMind
Copy link
Contributor

fix hosting category output after CloudFront is removed

fix #402

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

fix hosting category output after CloudFront is removed

fix aws-amplify#402
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #6041 (304aabf) into master (db9bf58) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6041   +/-   ##
=======================================
  Coverage   58.21%   58.21%           
=======================================
  Files         440      440           
  Lines       20160    20160           
  Branches     3988     3988           
=======================================
  Hits        11736    11736           
  Misses       7609     7609           
  Partials      815      815           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db9bf58...304aabf. Read the comment docs.

Copy link
Contributor

@jhockett jhockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhockett jhockett merged commit a2c1577 into aws-amplify:master Jan 22, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After removing cloudFront (Hosting endpoint information is not updated).
2 participants