Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #4175 - enable Cognito case insensitive usernames for new projects and new auth resources #6065

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

attilah
Copy link
Contributor

@attilah attilah commented Dec 4, 2020

Issue #, if available:

fix: #4175 - enable Cognito case insensitive usernames for new projects behind a feature flag.

Description of changes:

auth.enableCaseInsensitivity feature flag was added to not to break existing deployment. When a new auth resource is added and the flag's value is true case insensitivity for Cognito User Pools will be enabled.

New projects created will have this enabled by default.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@attilah attilah changed the title fix: #4175 - enable Cognito case insensitive usernames for new projects fix: #4175 - enable Cognito case insensitive usernames for new projects and new auth resources Dec 4, 2020
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #6065 (78529fb) into master (820e733) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6065      +/-   ##
==========================================
- Coverage   58.32%   58.31%   -0.01%     
==========================================
  Files         446      446              
  Lines       20274    20278       +4     
  Branches     4009     3802     -207     
==========================================
+ Hits        11824    11826       +2     
- Misses       7630     7652      +22     
+ Partials      820      800      -20     
Impacted Files Coverage Δ
.../awscloudformation/utils/auth-defaults-appliers.ts 62.96% <33.33%> (-3.71%) ⬇️
.../src/provider-utils/awscloudformation/constants.ts 100.00% <100.00%> (ø)
...amplify-cli-core/src/feature-flags/featureFlags.ts 80.58% <100.00%> (+0.09%) ⬆️
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
packages/graphql-mapping-template/src/print.ts 35.29% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts 0.00% <0.00%> (ø)
...es/amplify-util-mock/src/api/resolver-overrides.ts 0.00% <0.00%> (ø)
...es/graphql-transformer-core/src/stripDirectives.ts 35.29% <0.00%> (ø)
.../amplify-cli-core/src/state-manager/pathManager.ts 67.85% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 820e733...78529fb. Read the comment docs.

Copy link
Member

@edwardfoyle edwardfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment. Also, are we surfacing this functionality to customers in any way besides the FF docs? (ie if I have an existing project and I wanted to make this change, how would I learn about this)


this.registerFlag('auth', [
{
name: 'enableCaseInsensitivity',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's kinda confusing that the FF is "case insensitive" but the CFN value is "case sensitive". I'd recommend naming the FF "isUsernameCaseSensitive"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aligns with how it is named in the Cognito Console. That's the reason for the naming, I agree that comparing CFN and this counter intuitive, but in the Cognito Console it is like this.

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hugo & React to have same appsync Graphql API
3 participants