-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #4175 - enable Cognito case insensitive usernames for new projects and new auth resources #6065
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6065 +/- ##
==========================================
- Coverage 58.32% 58.31% -0.01%
==========================================
Files 446 446
Lines 20274 20278 +4
Branches 4009 3802 -207
==========================================
+ Hits 11824 11826 +2
- Misses 7630 7652 +22
+ Partials 820 800 -20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment. Also, are we surfacing this functionality to customers in any way besides the FF docs? (ie if I have an existing project and I wanted to make this change, how would I learn about this)
|
||
this.registerFlag('auth', [ | ||
{ | ||
name: 'enableCaseInsensitivity', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's kinda confusing that the FF is "case insensitive" but the CFN value is "case sensitive". I'd recommend naming the FF "isUsernameCaseSensitive"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This aligns with how it is named in the Cognito Console. That's the reason for the naming, I agree that comparing CFN and this counter intuitive, but in the Cognito Console it is like this.
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
fix: #4175 - enable Cognito case insensitive usernames for new projects behind a feature flag.
Description of changes:
auth.enableCaseInsensitivity
feature flag was added to not to break existing deployment. When a new auth resource is added and the flag's value is true case insensitivity for Cognito User Pools will be enabled.New projects created will have this enabled by default.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.