Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined appId destructuring #6092

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

edwardfoyle
Copy link
Member

@edwardfoyle edwardfoyle commented Dec 7, 2020

Issue #, if available:
fixes #6087
Description of changes:
Default to {} instead of undefined in _.get() appId

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #6092 (cd50c5b) into master (747d290) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6092   +/-   ##
=======================================
  Coverage   56.99%   56.99%           
=======================================
  Files         466      466           
  Lines       21402    21402           
  Branches     4029     4029           
=======================================
  Hits        12199    12199           
  Misses       8254     8254           
  Partials      949      949           
Impacted Files Coverage Δ
...der-awscloudformation/src/configuration-manager.js 4.17% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3235b4...cd50c5b. Read the comment docs.

@SwaySway SwaySway merged commit b817664 into aws-amplify:master Dec 11, 2020
@idobleicher
Copy link

Please reopen, I am using 4.42.0 and still having this issue.
Cannot destructure property 'appId' of '_.get(...)' as it is undefined.

@idobleicher
Copy link

image

@idobleicher
Copy link

@jhockett @edwardfoyle

@jhockett
Copy link
Contributor

jhockett commented Mar 4, 2021

@iuyt9003 this is a pull request. There's nothing to reopen here. If you upgrade to the latest CLI and still see this error, please open a new issue so we can debug what's going on in your case.

@github-actions
Copy link

github-actions bot commented Mar 5, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot destructure property 'appId' of '_.get(...)' as it is undefined.
4 participants