Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #6067 - nodejs mock return error from lambda #6096

Merged
merged 1 commit into from
Dec 11, 2020
Merged

fix: #6067 - nodejs mock return error from lambda #6096

merged 1 commit into from
Dec 11, 2020

Conversation

attilah
Copy link
Contributor

@attilah attilah commented Dec 7, 2020

Issue #, if available:

fix: #6067

Description of changes:

This fixes the error scenarios with mock when Lambda resolvers are used, either with throw or the callback('error') way.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@attilah attilah requested a review from yuth December 7, 2020 22:07
@attilah attilah added the mock Issues tied to the mock functionality label Dec 7, 2020
Copy link
Contributor

@yuth yuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some tests would be appreciated

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #6096 (df0c116) into master (747d290) will decrease coverage by 0.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6096      +/-   ##
==========================================
- Coverage   56.99%   56.99%   -0.01%     
==========================================
  Files         466      466              
  Lines       21402    21403       +1     
  Branches     4029     4030       +1     
==========================================
  Hits        12199    12199              
- Misses       8254     8255       +1     
  Partials      949      949              
Impacted Files Coverage Δ
...es/amplify-appsync-simulator/src/velocity/index.ts 75.43% <0.00%> (ø)
...ejs-function-runtime-provider/src/utils/execute.ts 71.92% <0.00%> (-1.29%) ⬇️
...dejs-function-runtime-provider/src/utils/invoke.ts 88.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 747d290...df0c116. Read the comment docs.

@SwaySway SwaySway merged commit d6793c8 into aws-amplify:master Dec 11, 2020
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
mock Issues tied to the mock functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors are not returned in Lambda Resolvers
3 participants