fix: correctly initialize Array when values contain a single integer element #6235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
When a request to an external data source returns a single value that is of type number, the array is incorrectly initialized. This scenario means that all requests to ElasticSearch with results sorted by date fail.
For example, when querying a locally running ElasticSearch instance with results sorted by date, the date is always returned is in milliseconds: 1608657312744. Since that value is a number, the call to
super(...values)
becomes
super(1608657312744)
Which tries to initialize an array of length 1608657312744. See the documentation: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/Array
This pull request correctly initializes the array when the length is 1.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.