Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removes nodeModules from curBackend #6261

Merged
merged 3 commits into from
Jan 5, 2021

Conversation

akshbhu
Copy link
Contributor

@akshbhu akshbhu commented Dec 25, 2020

Description of changes:

Removing NodeModules folder from the #currentcloudbackend

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@akshbhu akshbhu requested a review from a team as a code owner December 25, 2020 00:48
@codecov
Copy link

codecov bot commented Dec 25, 2020

Codecov Report

Merging #6261 (14fa181) into master (20f2181) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6261      +/-   ##
==========================================
+ Coverage   57.03%   57.12%   +0.08%     
==========================================
  Files         469      471       +2     
  Lines       21514    21554      +40     
  Branches     4272     4066     -206     
==========================================
+ Hits        12271    12313      +42     
- Misses       8363     8381      +18     
+ Partials      880      860      -20     
Impacted Files Coverage Δ
...xtensions/amplify-helpers/service-select-prompt.ts 94.59% <100.00%> (ø)
.../amplify-util-mock/src/api/lambda-arn-to-config.ts 100.00% <100.00%> (ø)
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
packages/graphql-mapping-template/src/print.ts 35.29% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts 0.00% <0.00%> (ø)
...es/amplify-util-mock/src/api/resolver-overrides.ts 0.00% <0.00%> (ø)
...es/graphql-transformer-core/src/stripDirectives.ts 35.29% <0.00%> (ø)
.../amplify-cli-core/src/state-manager/pathManager.ts 67.44% <0.00%> (ø)
.../amplify-util-mock/src/utils/lambda/loadMinimal.ts 0.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b57b05d...14fa181. Read the comment docs.

Copy link
Contributor

@jhockett jhockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jhockett jhockett merged commit db9dca9 into aws-amplify:master Jan 5, 2021
@github-actions
Copy link

github-actions bot commented Jan 5, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants