Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default sourceDir for react-native projects to 'src' #6319

Merged
merged 1 commit into from
Jan 6, 2021

Conversation

edwardfoyle
Copy link
Member

Issue #, if available:
#6269

Description of changes:
change default SourceDir from / to src for react-native projects. This is consistent with other project structures and removes a disparity between where types were generated and where the CLI tries to locate them by default.

Tested in projects initialized using expo and react-native CLI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edwardfoyle edwardfoyle requested a review from a team as a code owner January 5, 2021 23:26
@edwardfoyle edwardfoyle requested review from nikhname and removed request for a team January 5, 2021 23:28
Copy link
Contributor

@nikhname nikhname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #6319 (61075c6) into master (091e148) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #6319    +/-   ##
========================================
  Coverage   57.12%   57.12%            
========================================
  Files         471      471            
  Lines       21554    21554            
  Branches     4066     4281   +215     
========================================
  Hits        12313    12313            
+ Misses       8381     8361    -20     
- Partials      860      880    +20     
Impacted Files Coverage Δ
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
packages/graphql-mapping-template/src/print.ts 35.29% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts 0.00% <0.00%> (ø)
...es/amplify-util-mock/src/api/resolver-overrides.ts 0.00% <0.00%> (ø)
...es/graphql-transformer-core/src/stripDirectives.ts 35.29% <0.00%> (ø)
.../amplify-cli-core/src/state-manager/pathManager.ts 67.44% <0.00%> (ø)
.../amplify-util-mock/src/utils/lambda/loadMinimal.ts 0.00% <0.00%> (ø)
...graphql-transformer-core/src/TransformerContext.ts 25.09% <0.00%> (ø)
...mplify-appsync-simulator/src/resolvers/function.ts 15.38% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 091e148...61075c6. Read the comment docs.

@jhockett jhockett merged commit 6ebbe41 into aws-amplify:master Jan 6, 2021
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants