Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql-auth-transformer): fix field auth with connection #6320

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

SwaySway
Copy link
Contributor

@SwaySway SwaySway commented Jan 5, 2021

make sure to return the result if auth is used on a connection field

fix #4760

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

make sure to return the result if auth is used on a connection field

fix aws-amplify#4760
@SwaySway SwaySway requested a review from a team as a code owner January 5, 2021 23:58
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #6320 (fd92b13) into master (0c9c181) will increase coverage by 0.03%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6320      +/-   ##
==========================================
+ Coverage   57.12%   57.16%   +0.03%     
==========================================
  Files         471      471              
  Lines       21554    21556       +2     
  Branches     4066     4282     +216     
==========================================
+ Hits        12313    12322       +9     
+ Misses       8381     8353      -28     
- Partials      860      881      +21     
Impacted Files Coverage Δ
packages/graphql-auth-transformer/src/resources.ts 77.31% <66.66%> (-0.24%) ⬇️
...aphql-auth-transformer/src/ModelAuthTransformer.ts 88.65% <100.00%> (+0.88%) ⬆️
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
packages/graphql-mapping-template/src/print.ts 35.29% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts 0.00% <0.00%> (ø)
...es/amplify-util-mock/src/api/resolver-overrides.ts 0.00% <0.00%> (ø)
...es/graphql-transformer-core/src/stripDirectives.ts 35.29% <0.00%> (ø)
.../amplify-cli-core/src/state-manager/pathManager.ts 67.44% <0.00%> (ø)
.../amplify-util-mock/src/utils/lambda/loadMinimal.ts 0.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c9c181...fd92b13. Read the comment docs.

@attilah attilah requested a review from yuth January 7, 2021 20:32
Copy link
Contributor

@yuth yuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@attilah attilah merged commit 8cc85d0 into aws-amplify:master Jan 7, 2021
@github-actions
Copy link

github-actions bot commented Jan 8, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection always returns null when adding @auth
3 participants