Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regression from #6132 #6370

Merged
merged 1 commit into from Jan 12, 2021
Merged

fix: regression from #6132 #6370

merged 1 commit into from Jan 12, 2021

Conversation

attilah
Copy link
Contributor

@attilah attilah commented Jan 12, 2021

Issue #, if available:

N/A

Description of changes:

Fix a regression from #6132 when frontend configuration for Android projects did not include the resources after push

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #6370 (60d040e) into master (5ebcae8) will increase coverage by 0.10%.
The diff coverage is 72.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6370      +/-   ##
==========================================
+ Coverage   57.10%   57.20%   +0.10%     
==========================================
  Files         471      473       +2     
  Lines       21563    21595      +32     
  Branches     4284     4075     -209     
==========================================
+ Hits        12313    12354      +41     
- Misses       8369     8381      +12     
+ Partials      881      860      -21     
Impacted Files Coverage Δ
...amplify-category-notifications/lib/channel-APNS.js 62.92% <0.00%> (ø)
packages/amplify-cli-core/src/exitOnNextTick.ts 50.00% <0.00%> (+10.00%) ⬆️
packages/amplify-cli-core/src/index.ts 94.73% <ø> (ø)
...ckages/amplify-cli/src/init-steps/postInitSetup.ts 20.00% <0.00%> (ø)
...ackages/amplify-cli/src/init-steps/preInitSetup.ts 80.00% <0.00%> (ø)
.../amplify-frontend-ios/lib/amplify-config-helper.js 1.01% <0.00%> (ø)
...mplify-frontend-ios/lib/frontend-config-creator.js 16.44% <0.00%> (+0.21%) ⬆️
...der-awscloudformation/src/configuration-manager.ts 6.63% <0.00%> (ø)
...der-awscloudformation/src/system-config-manager.js 7.14% <0.00%> (ø)
...vider-awscloudformation/src/utils/admin-helpers.ts 23.68% <ø> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a045fb...60d040e. Read the comment docs.

@ammarkarachi ammarkarachi merged commit 9dcd118 into aws-amplify:master Jan 12, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants